Skip to content

Check update for every 5 minutes (temp) #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iAziz786 merged 1 commit into from
Jan 26, 2026
Merged

Check update for every 5 minutes (temp) #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions config/appconf/appconf.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,11 @@ func SelfUpdateEnabled() bool {
}

// UpdateCheckInterval returns the interval between update checks.
// Controlled by HOSTLINK_UPDATE_CHECK_INTERVAL (default: 1h, clamped to [1m, 24h]).
// Controlled by HOSTLINK_UPDATE_CHECK_INTERVAL (default: 5m, clamped to [1m, 24h]).
func UpdateCheckInterval() time.Duration {
const (
defaultInterval = 1 * time.Hour
// TODO(SLFHOST-11): revert to 1*time.Hour once self-update debugging is complete
defaultInterval = 5 * time.Minute
minInterval = 1 * time.Minute
maxInterval = 24 * time.Hour
)
Expand Down
6 changes: 3 additions & 3 deletions config/appconf/appconf_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ func TestSelfUpdateEnabled_InvalidFallsToDefault(t *testing.T) {
assert.True(t, SelfUpdateEnabled())
}

func TestUpdateCheckInterval_Default1h(t *testing.T) {
func TestUpdateCheckInterval_Default5m(t *testing.T) {
t.Setenv("HOSTLINK_UPDATE_CHECK_INTERVAL", "")
assert.Equal(t, 1*time.Hour, UpdateCheckInterval())
assert.Equal(t, 5*time.Minute, UpdateCheckInterval())
}

func TestUpdateCheckInterval_CustomValue(t *testing.T) {
Expand All @@ -49,7 +49,7 @@ func TestUpdateCheckInterval_ClampedToMax(t *testing.T) {

func TestUpdateCheckInterval_InvalidFallsToDefault(t *testing.T) {
t.Setenv("HOSTLINK_UPDATE_CHECK_INTERVAL", "garbage")
assert.Equal(t, 1*time.Hour, UpdateCheckInterval())
assert.Equal(t, 5*time.Minute, UpdateCheckInterval())
}

func TestUpdateLockTimeout_Default5m(t *testing.T) {
Expand Down