Upgrade to NAN 2.1.0 for Node 4 support #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
PR #10 is more comprehensive and should supersede this PR, but this one may be easier to review and merge. It's causing a warning/error for people using packages that depend on crypt3. |
|
👍 This is much simpler than my approach. I didn't know anything about native extensions for node before this. |
Contributor
Author
Contributor
Author
|
Updated to compile without warnings on NAN 2.1.0. |
Contributor
Author
|
ping |
Member
|
Sorry, I have been busy with other work. |
thejhh
added a commit
that referenced
this pull request
Nov 7, 2015
Upgrade to NAN 2.1.0 for Node 4 support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11