Skip to content

Handle null values when sorting by StringOrdComparator #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wesleygong wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle null values when sorting by StringOrdComparator #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions bobo-browse/src/main/java/com/browseengine/bobo/sort/DocComparatorSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,10 @@ public int compare(ScoreDoc doc1, ScoreDoc doc2) {
}

public String value(ScoreDoc doc) {
if (values.lookup[values.order[doc.doc]] == null) {
return null;
}

return String.valueOf(values.lookup[values.order[doc.doc]]);
}
};
Expand Down
10 changes: 10 additions & 0 deletions bobo-browse/src/main/java/com/browseengine/bobo/sort/ReverseDocComparatorSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,16 @@ public static class ReverseComparable implements Comparable,Serializable{
public int compareTo(Object o) {
if (o instanceof ReverseComparable){
Comparable inner = ((ReverseComparable)o)._inner;

if (_inner == null) {
if (inner == null) {
return 0;
}
return 1;
} else if (inner == null) {
return -1;
}

return -_inner.compareTo(inner);
}
else{
Expand Down