Upgrade EBS volume type from gp2 to gp3 in EC2 launch templates#2116
Open
igor-soldev wants to merge 1 commit intosequinstream:mainfrom
Open
Upgrade EBS volume type from gp2 to gp3 in EC2 launch templates#2116igor-soldev wants to merge 1 commit intosequinstream:mainfrom
igor-soldev wants to merge 1 commit intosequinstream:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the default EBS volume type from
gp2togp3in the EC2 launch templates for bothterraform-ecs-ec2andterraform-ecs-ec2-sqsdeployment setups.Why is this change necessary?
As discussed with Carter on the Sequin Community Slack, upgrading to
gp3provides immediate benefits for anyone self-hosting Sequin on AWS:gp3volumes are up to 20% cheaper per GB compared togp2.gp3provides a baseline of 3,000 IOPS and 125 MB/s throughput regardless of volume size, eliminating the burst-credit limitations inherent togp2.Additionally, I removed the
iops = "0"parameter, asgp3volumes require either a minimum of3000IOPS or the parameter can be omitted entirely (AWS defaults it to3000forgp3). Settingiops = 0withgp3will cause a Terraform validation error.(Note: The diff shows
iops = "0"being removed, which is the correct approach when migrating togp3without explicitly defining custom IOPS).How was this identified?
This opportunity was identified while running a static infrastructure analysis on the
deployment/directory using InfraScan (an open-source FinOps/SecOps tool by SolDevelo).You can view the full report that highlighted this here:
View InfraScan Report for Sequin
Testing
gp3.