Skip to content

Comments

support the same tags on a one level#40

Open
aleksei4er wants to merge 2 commits intosergiorodenas:masterfrom
aleksei4er:master
Open

support the same tags on a one level#40
aleksei4er wants to merge 2 commits intosergiorodenas:masterfrom
aleksei4er:master

Conversation

@aleksei4er
Copy link

@aleksei4er aleksei4er commented Sep 21, 2022

The problem is parser takes the last tag in case of the same tags are on a one level.

For example:

<image>1</image>
<image>2</image>
<image>3</image>

$collection->get('image')

It's gonna be 3 in result

@aleksei4er aleksei4er changed the title support the same tags on level support the same tags on one level Sep 21, 2022
@aleksei4er aleksei4er changed the title support the same tags on one level support the same tags on a one level Sep 21, 2022
@sergiorodenas
Copy link
Owner

Isn't this managed on https://github.com/sergiorodenas/stream-parser/blob/master/tests/Parsers/XMLParserTest.php#L82 ?

If it's not the case, could we test it with a stub?

Thank you so much for the suggestion anyway!! 💪🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants