Skip to content

fix(config): use double dash for dot #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drgroot merged 1 commit into from
Jan 19, 2025
Merged

fix(config): use double dash for dot #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions servc/svc/config/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def __init__(self, config_path: str | None = None):
raise Exception("Configuration file does not match the configuration path")

def get(self, key: str) -> Any:
keys = key.lower().split(".")
keys = [x.replace("--", ".") for x in key.lower().split(".")]
subconfig = self._configDictionary

for index, subkey in enumerate(keys):
Expand All @@ -71,7 +71,7 @@ def get(self, key: str) -> Any:
subconfig = subconfig.get(subkey, {})

def setValue(self, key: str, value: Any):
keys = key.lower().split(".")
keys = [x.replace("--", ".") for x in key.lower().split(".")]
subconfig = self._configDictionary

for index, subkey in enumerate(keys):
Expand Down
8 changes: 7 additions & 1 deletion tests/svc/test_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,13 @@ def test_value(self):
self.assertEqual(self.config.get("conf.bus.prefix"), "test")

self.config.setValue("conf.bus.routemap.api", "test_route")
self.assertEqual(self.config.get("conf.bus.routemap.api"), "test_route")
self.assertEqual(self.config.get(
"conf.bus.routemap.api"), "test_route")

self.config.setValue("conf.bus.routemap--api", "test_route")
self.assertEqual(self.config.get(
"conf.bus.routemap--api"), "test_route")
self.assertIn("routemap.api", self.config.get('conf.bus'))

def test_wrong_location(self):
try:
Expand Down
Loading