feat: unit tests for the data.ts class#1566
Open
javabudd wants to merge 28 commits intosession-foundation:devfrom
Open
feat: unit tests for the data.ts class#1566javabudd wants to merge 28 commits intosession-foundation:devfrom
javabudd wants to merge 28 commits intosession-foundation:devfrom
Conversation
…sNotInPool, saveConversation
…nversation, getAllConversations
Contributor
Author
|
The currently failing test is due to non-deterministic timing issues from a test not associated with this PR. |
Bilb
force-pushed
the
dev
branch
4 times, most recently
from
9482711 to
0e508e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist:
devbranchyarn readyrun passes successfully (more about tests here)Description
Adds unit tests for the
ts/data/data.tsclass.Fixes a type issue on the skipTimerInit property.