Emit beneficiary on new contribution, always#11
Merged
darcys22 merged 6 commits intosession-foundation:masterfrom Apr 22, 2025
Conversation
…s, the correct one
…a for the upgraded contracts
For external tools tracking the state of the contract, the initial contribution to the contract was not emitting the beneficiary which meant they were unable to rederive the state of the contract from the events alone.
Doy-lee
changed the title
darcys22
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the staking portal trying to track the state of multi-contrib. There's multiple commits here updating the upgrade-metadata. There were some changes we deployed that I never merged back to master because I was waiting for confirmation that the changes fixed the issues we had on the staking portal. That's been all cleared now hence the PR.