Conversation
Upgrade all Charm dependencies from github.com/charmbracelet/* to charm.land/*/v2 vanity import paths: - bubbletea v2: View() returns tea.View with declarative AltScreen, KeyMsg replaced by KeyPressMsg with new field names - lipgloss v2: Color is now a function returning color.Color - bubbles v2: textinput styles via getter/setter, viewport New() with SetWidth/SetHeight, Width field becomes Width() getter - glamour v2: import path change only (pseudo-version from v2-exp) Replace termenv.HasDarkBackground() with tea.RequestBackgroundColor and tea.BackgroundColorMsg for non-blocking background detection. BREAKING CHANGE: requires Charm v2 ecosystem (charm.land module paths) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
In lipgloss v2, Style.Width() now includes border size in the total width (borders are drawn inside the specified width). Add GetHorizontalBorderSize() to header width calculations so the header boxes match the viewport box alignment. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
In lipgloss v2, BorderStyle() only sets the visual style of the border but does not enable border rendering. Border() both sets the style and enables all sides. This caused the viewport box to render without borders, breaking alignment with the header boxes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
🎬 Demo
Generated by workflow run. Run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade all Charm dependencies from github.com/charmbracelet/* to charm.land/*/v2 vanity import paths:
Replace termenv.HasDarkBackground() with tea.RequestBackgroundColor and tea.BackgroundColorMsg for non-blocking background detection.
BREAKING CHANGE: requires Charm v2 ecosystem (charm.land module paths)