Skip to content

Implement hem feature#562

Draft
pierreporte wants to merge 2 commits intoshaise:masterfrom
pierreporte:hems
Draft

Implement hem feature#562
pierreporte wants to merge 2 commits intoshaise:masterfrom
pierreporte:hems

Conversation

@pierreporte
Copy link

@pierreporte pierreporte commented Mar 9, 2026

Resolves #302

This is my first code contribution to the workbench. I’m not a programmer, I just know a little bit of Python. I’ve never worked on an existing code base before.

What is needed to do, as I see it now:

What I don’t want to do with this PR:

  • Improving support for miter
  • Improving support for corner relief

@pierreporte
Copy link
Author

@shaise SheetMetalCmd.py is very big. Do you think that SMWall and SMHem classes (and accessories) should be in a separate file each?

@maxwxyz
Copy link
Contributor

maxwxyz commented Mar 9, 2026

@pierreporte
SheetMetal_AddHem

@pierreporte
Copy link
Author

It’s exactly what I had in mind, thanks!

Though is this normal to have blue inside the bend?

image

@maxwxyz
Copy link
Contributor

maxwxyz commented Mar 9, 2026

ah no, will correct it

@shaise
Copy link
Owner

shaise commented Mar 10, 2026

@pierreporte
Nice!!
Yes, please put smHem in a separate file.
Also, is there a task panel for that?

shai

@maxwxyz
Copy link
Contributor

maxwxyz commented Mar 10, 2026

@pierreporte
SheetMetal_AddHem

@pierreporte
Copy link
Author

Thanks @maxwxyz

@shaise There is no task panel yet. I will certainly need help for it. Now I need to get the math right because I want to change the width users will enter, then I’ll split the file and try to solve issues when editing the tree. The task panel should be the last one.

@shaise
Copy link
Owner

shaise commented Mar 11, 2026

@pierreporte ,

No problem, do what you can, I will deal with the task panel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Simple way to make hems

3 participants