Open
Conversation
No functional change.
When processing arguments to API functions, we generally want to test only whether a variable is defined. We then rely on the regular JavaScript type conversion rules for handling values of the wrong type, including null. Introduce a new isDefined() helper for this case. Also fix the test for a parent in TimedItem(). This was broken in 2998dbb, which caused test-parent to fail.
…tionDuration TimedItem.updateIterationDuration() uses parent, _startTime, _timeDrift and _locallyPaused, so these must be initialized before the method is called. Also remove superfluous logic to (incorrectly) set endTime, as this is done correctly in updateIterationDuration().
See https://dvcs.w3.org/hg/FXTF/raw-file/tip/web-anim/index.html#the-intrinsic-duration-of-a-parallel-animation-group Currently, the intrinisic duration of an empty par group is -Infinity, because that is the value of Math.max.apply([]).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was broken in 2998dbb, which caused
test-parent to fail.