Iteration start clipping#30
Open
steveblock wants to merge 2 commits intoshans:masterfrom
steveblock:iterationStartClipping
Open
Iteration start clipping#30steveblock wants to merge 2 commits intoshans:masterfrom steveblock:iterationStartClipping
steveblock wants to merge 2 commits intoshans:masterfrom
steveblock:iterationStartClipping
Conversation
This was broken by 26b922e, which updated TimedItem to throw exceptions if iterationStart or iterationCount are negative, as required by the spec.
This was agreed in item 4c of Meeting 35 (https://etherpad.mozilla.org/7Qo6P4kYyD) and requires a spec change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.