Open
Conversation
Renamed Old table name format
shayonj
reviewed
Feb 13, 2024
| # happens at all times. IOW, the calls from Store.get always return | ||
| # the same value. | ||
| Store.set(:old_primary_table, "pgosc_op_table_#{client.table.downcase}") | ||
| Store.set(:old_primary_table, "pgosc_op_table_#{client.table.downcase}_#{pgosc_identifier}") |
Owner
There was a problem hiding this comment.
Looks like the spec is failing due to the length. We would like to keep this length to 20 or maybe 21 characters, to not accidentally overflow in case the actual table name is longer and then result into production errors, since PG has a table name length limit.
Do you want to see if you can repurpose the logic here to perhaps add an index (numeric). For example pgosc_op_table_foobar_1.
Note: If _1 already exists, then it should automatically increment the index from the previous value.
It requires updating a few code paths and specs, so I am happy to take it over too. Let me know 🙌🏾
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed Old table name format