feat: allowing extension list to feature extensions with two dots (e.g. module.less, module.css)#35
Open
Robbie-Cook wants to merge 1 commit intosheerun:masterfrom
Open
feat: allowing extension list to feature extensions with two dots (e.g. module.less, module.css)#35Robbie-Cook wants to merge 1 commit intosheerun:masterfrom
module.less, module.css)#35Robbie-Cook wants to merge 1 commit intosheerun:masterfrom
Conversation
fix: add tests fix: fix fix: fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should be able to allow people to use extensions with multiple
.s in them.This PR passes all tests, and should hopefully not break anyone's existing code. The one inconsistency is that if people have files extensions with multiple dots that are supposed to be excluded, these will now be included.
For this reason, I suggest a
minor/majorversion.