Open
Conversation
…`from_stream` work on any field. Also added some tests and updated the messages documentation
…bytes` and `from_stream`, also added support for `from_stream` in all of the fields and it is now a requirement to create a new field (one of the abstract methods in the abstract class `Field`)
… OpcodeField logic, also removed all of the `from_bytes` logic in all of the Field and now its calling to `from_stream` with a mock reader
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from_bytesandfrom_streamfrom_streamin all of the fields and now it's a requirement to create a new field (it's an abstract function in the abstract classField)from_stream