Open
Conversation
Owner
|
To be honest, I am very strongly against using synchronous network operations (HTTP requests) in the context of an asynchronous library, especially considering the fact, that there is a solid HTTP implementation in twisted itself. I would replace the use of "requests" (and the uncalled for introduction of external dependency) with the use of twisted.http.client. Perhaps, I'll find some time in the following week or two to do it myself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basic concept of this backend is to forward TFTP queries "as is" to an
HTTP server, as a simple way to allow dynamic files generated on the fly for
each TFTP request.
RRQ are forwarded as GET requests.
WRQ are forwarded as PUT requests.