Fix #160: Anchor IsJSON regex to prevent false positives on CDATA#163
Open
bukzor wants to merge 1 commit intosibprogrammer:masterfrom
Open
Fix #160: Anchor IsJSON regex to prevent false positives on CDATA#163bukzor wants to merge 1 commit intosibprogrammer:masterfrom
bukzor wants to merge 1 commit intosibprogrammer:masterfrom
Conversation
bukzor
force-pushed
the
fix-160-isjson-regex
branch
from
44e1d28 to
a11677f
Compare
bukzor
force-pushed
the
fix-160-isjson-regex
branch
from
a11677f to
4629951
Compare
… on CDATA
The IsJSON() function was using an unanchored regex `\s*[{\[]` which
would match a `[` character anywhere in the input. This caused XML
documents containing CDATA sections like `<![CDATA[text]]>` to be
incorrectly detected as JSON.
Changed the regex to `^\s*[{\[]` to anchor it to the start of the
input string. Now only inputs that actually begin with `{` or `[`
(after optional whitespace) will be detected as JSON.
Added TestIsJSON with test cases including CDATA to verify the fix.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
bukzor
force-pushed
the
fix-160-isjson-regex
branch
from
4629951 to
9a5c191
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #163 +/- ##
=======================================
Coverage 80.57% 80.57%
=======================================
Files 5 5
Lines 690 690
=======================================
Hits 556 556
Misses 92 92
Partials 42 42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes part of issue #160 by anchoring the
IsJSON()regex to prevent false positives when detecting format.Problem: The
IsJSON()function uses an unanchored regex\s*[{\[]which matches a[character anywhere in the input. This causes XML documents containing CDATA sections like<![CDATA[text]]>to be incorrectly detected as JSON format.Solution: Changed the regex to
^\s*[{\[]to anchor it to the start of the input string. Now only inputs that actually begin with{or[(after optional whitespace) will be detected as JSON.Changes
IsJSON()to use anchored regex^\s*[{\[]TestFormatDetectiontest to verify CDATA sections are correctly detected as XML formatTest Plan
TestFormatDetection/CDATA_should_be_detected_as_XML_not_JSONgo test ./...)Additional Context
This is part 2 of a 4-part fix for issue #160. The other PRs address:
🤖 Generated with Claude Code