Open
Conversation
added 9 commits
September 22, 2016 17:36
…nstead of crashing
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So this should be a good start at implementing the 'Set' function: we should be able to actually 'Get' and 'Set' DBus properties now!
I have tested with single types as well as complex / containers type. I have tried several "nested" cases, but it is entirely possible that I've left some aside. So please test and report if there are some use-cases that won't work. We'll try to fix it in the mean time.
Also, I must have messed up my branches because in the
diffI see that I have included the changed inindex.jsconcerning interface and error names checking.So basically, I have made a function that checks an error and interface name against the DBus naming convention.
I have included this chekc in
bus.sendError()andbus.exportInterface()so that it's not possible to export an interface whose name meet DBus naming requirements (or send an error whose name doesn't).I'm sorry, it should have been in a separate branch, in a separate issue, but I messed this up somehow. I am not motivated enough to rebase, especially since this is a minor change :-)