Fix variants, add tests#143
Open
mvduin wants to merge 4 commits intosidorares:masterfrom
dutchanddutch:fix-variants
Open
Fix variants, add tests#143mvduin wants to merge 4 commits intosidorares:masterfrom dutchanddutch:fix-variants
mvduin wants to merge 4 commits intosidorares:masterfrom
dutchanddutch:fix-variants
Conversation
Owner
|
Thanks Matthijs , I really hope to find time soon to review all pending PRs on this project, was very very busy lately |
This is e.g. for variants, and includes the small optimization for the simplest cases that's currently done in marshall.
Merged
Contributor
Author
|
Just letting you know that I no longer care about this PR. I wrote my own dbus module instead. |
Owner
|
@mvduin Sorry to hear that. I'm happy to add link to your module from readme here |
|
@sidorares : can this be merged if the conflict is resolved? This is helpful for eslint, so I'd like to merge it before prettifying. |
|
So obviously that didn't happen, but I'd still like to see a fix for variants. Can you review it @sidorares |
|
@sidorares : so how about this one? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They were apparently quite broken...
before:
after: