Skip to content

Comments

fix: fix wrong length number write to packet#3177

Merged
wellwelwel merged 5 commits intosidorares:masterfrom
remones:bugfix/fix-big-data-stmt
Feb 21, 2026
Merged

fix: fix wrong length number write to packet#3177
wellwelwel merged 5 commits intosidorares:masterfrom
remones:bugfix/fix-big-data-stmt

Conversation

@remones
Copy link
Contributor

@remones remones commented Nov 1, 2024

No description provided.

@codecov
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.15%. Comparing base (c259560) to head (408bd04).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3177      +/-   ##
==========================================
+ Coverage   89.98%   90.15%   +0.16%     
==========================================
  Files          86       86              
  Lines       13693    13692       -1     
  Branches     1643     1647       +4     
==========================================
+ Hits        12322    12344      +22     
+ Misses       1371     1348      -23     
Flag Coverage Δ
compression-0 89.38% <100.00%> (+0.16%) ⬆️
compression-1 90.13% <100.00%> (+0.16%) ⬆️
static-parser-0 87.74% <100.00%> (+0.16%) ⬆️
static-parser-1 88.50% <100.00%> (+0.16%) ⬆️
tls-0 89.56% <100.00%> (+0.16%) ⬆️
tls-1 89.92% <100.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wellwelwel
Copy link
Collaborator

Hi, @remones 🙋🏻‍♂️

Could you provide some context?
As a fix, do you think a test can be added to cover the issue that is being fixed?

@remones
Copy link
Contributor Author

remones commented Nov 7, 2024

Hi, @remones 🙋🏻‍♂️

Could you provide some context? As a fix, do you think a test can be added to cover the issue that is being fixed?

@wellwelwel I'm so sorry, I will provide the test code later.

Please let me explain the issue first: I have a node.js service uses mysql2 to access a MySQL proxy service. When attempting to write a 32MB TEXT field, it raises some errors. we found the reason is that the field length in the MySQL protocol packet read by the proxy far exceeds 32MB. I believe the issue is caused by JavaScript bitwise operations not supporting numbers larger than 32 bits.

wellwelwel

This comment was marked as resolved.

@wellwelwel wellwelwel merged commit 0e06e02 into sidorares:master Feb 21, 2026
88 checks passed
@wellwelwel
Copy link
Collaborator

Thanks, @remones! I fixed a RangeError issue and added tests to cover the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants