Skip to content

Comments

ci: fix benchmark#4120

Merged
wellwelwel merged 1 commit intosidorares:masterfrom
wellwelwel:bench
Feb 24, 2026
Merged

ci: fix benchmark#4120
wellwelwel merged 1 commit intosidorares:masterfrom
wellwelwel:bench

Conversation

@wellwelwel
Copy link
Collaborator

@wellwelwel wellwelwel commented Feb 24, 2026

Tis PR ensures that the benchmark runs on the master branch. This makes benchmarks
executed in PRs compare directly against HEAD.

Also, the 150% margin for triggering an alert has a compounding degradation problem:

  1. If a benchmark detects 149%, it doesn't notify and the test passes normally.
  2. If the next benchmark also has a 149% loss, that loss is on top of the "new 100%", resulting in ~222% (1.49 × 1.49) accumulated performance loss between two distinct PRs, for example.

The margin was reduced to 110% (for now), limiting this silent drift.

@wellwelwel wellwelwel marked this pull request as ready for review February 24, 2026 18:24
@wellwelwel wellwelwel merged commit f9ac466 into sidorares:master Feb 24, 2026
86 checks passed
@wellwelwel wellwelwel deleted the bench branch February 24, 2026 18:25
@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.21%. Comparing base (1952441) to head (8af3569).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4120   +/-   ##
=======================================
  Coverage   90.21%   90.21%           
=======================================
  Files          86       86           
  Lines       13740    13740           
  Branches     1660     1660           
=======================================
  Hits        12396    12396           
  Misses       1344     1344           
Flag Coverage Δ
compression-0 89.44% <ø> (ø)
compression-1 90.19% <ø> (ø)
static-parser-0 87.81% <ø> (ø)
static-parser-1 88.57% <ø> (ø)
tls-0 89.62% <ø> (ø)
tls-1 89.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant