fix(schematics): update split mapping#1532
Conversation
akashsonune
commented
Feb 16, 2026
- I confirm that this MR follows the contribution guidelines.
There was a problem hiding this comment.
Code Review
The pull request correctly adds the SplitOrientation symbol to the ELEMENT_NG_MAPPINGS, which is necessary for the schematic to migrate imports from the old @simpl package to the new @siemens package. I noticed that the new entry is placed out of alphabetical order relative to the rest of the file. Additionally, you might want to check if other exported types from the split package, such as CollapseTo, PartState, and Scale, also require mappings if they were previously available in the @simpl package.
| 'SiSplitComponent': '@siemens/element-ng/split', | ||
| 'SiSplitModule': '@siemens/element-ng/split', | ||
| 'SiSplitPartComponent': '@siemens/element-ng/split', | ||
| 'SplitOrientation': '@siemens/element-ng/split', |
There was a problem hiding this comment.
The entries in this file are sorted alphabetically by their symbol name (case-insensitive). SplitOrientation should be placed after SortOrder (around line 602) rather than being grouped with other SiSplit components. While I cannot provide a code suggestion for the correct location as it is outside the current diff hunk, please move this entry to maintain the file's sorting pattern.
|
Documentation. Coverage Reports: |