Skip to content

Comments

fix(schematics): update split mapping#1532

Open
akashsonune wants to merge 1 commit intorelease/48.xfrom
fix/update-correct-mapping
Open

fix(schematics): update split mapping#1532
akashsonune wants to merge 1 commit intorelease/48.xfrom
fix/update-correct-mapping

Conversation

@akashsonune
Copy link
Member

Describe in detail what your merge request does and why. Add relevant
screenshots and reference related issues via Closes #XY or Related to #XY.


Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request correctly adds the SplitOrientation symbol to the ELEMENT_NG_MAPPINGS, which is necessary for the schematic to migrate imports from the old @simpl package to the new @siemens package. I noticed that the new entry is placed out of alphabetical order relative to the rest of the file. Additionally, you might want to check if other exported types from the split package, such as CollapseTo, PartState, and Scale, also require mappings if they were previously available in the @simpl package.

'SiSplitComponent': '@siemens/element-ng/split',
'SiSplitModule': '@siemens/element-ng/split',
'SiSplitPartComponent': '@siemens/element-ng/split',
'SplitOrientation': '@siemens/element-ng/split',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The entries in this file are sorted alphabetically by their symbol name (case-insensitive). SplitOrientation should be placed after SortOrder (around line 602) rather than being grouped with other SiSplit components. While I cannot provide a code suggestion for the correct location as it is outside the current diff hunk, please move this entry to maintain the file's sorting pattern.

@github-actions
Copy link

Code Coverage

@github-actions
Copy link

@akashsonune akashsonune marked this pull request as ready for review February 17, 2026 09:25
@akashsonune akashsonune requested a review from a team as a code owner February 17, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants