Skip to content

Comments

fix(side-panel): fullscreen button visibility#1547

Open
dauriamarco wants to merge 1 commit intomainfrom
fix/side-panel/fullscrenn-btn-visibility
Open

fix(side-panel): fullscreen button visibility#1547
dauriamarco wants to merge 1 commit intomainfrom
fix/side-panel/fullscrenn-btn-visibility

Conversation

@dauriamarco
Copy link
Member

Closes #1529.

Describe in detail what your merge request does and why. Add relevant
screenshots and reference related issues via Closes #XY or Related to #XY.


@dauriamarco dauriamarco added this to the 49.x milestone Feb 18, 2026
@dauriamarco dauriamarco self-assigned this Feb 18, 2026
@dauriamarco dauriamarco requested review from a team as code owners February 18, 2026 21:14
@dauriamarco dauriamarco added the bug Something isn't working label Feb 18, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a visibility issue with the fullscreen button in the side panel. The change increases the specificity of the CSS selector for the fullscreen button, ensuring that its display property, which is controlled by a CSS variable for visibility, is not overridden by more general theme styles. The fix is correct and well-targeted. I have no further comments.

@github-actions
Copy link

@ljanner
Copy link
Member

ljanner commented Feb 18, 2026

Can we add a unit test to prevent future regressions 🤔 ? I'm unsure how good the setup around unit testing in the side-panel is - if it's a big hassle I'm fine with making testing improvements as follow up task.

@dauriamarco dauriamarco force-pushed the fix/side-panel/fullscrenn-btn-visibility branch from 7ff70fc to 896c3a8 Compare February 19, 2026 13:35
@dauriamarco dauriamarco requested a review from ljanner February 19, 2026 13:38
Copy link
Member

@ljanner ljanner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dauriamarco that's some serious test coverage you added! Well done 👏 🚀

Only a few minor details

Comment on lines +60 to 62
.btn-icon.fullscreen-button {
display: var(--fullscreen-button-display, inline-flex);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.btn-icon.fullscreen-button {
display: var(--fullscreen-button-display, inline-flex);
}
.fullscreen-button {
display: var(--fullscreen-button-display, inline-flex) !important; // stylelint-disable-line declaration-no-important
}

The reason why the fix with the additional .btn-icon specifier works is because this rule has higher specificity than the .btn class which applies display: flex. If anybody tries to figure out when what display value is set they need to play the game of specificity.

I generally think putting !important here would be a really valid choice, because it makes it more clear that it is an intentional value.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ljanner :) I understand your point here 👍 and I would also like to now what @spike-rabbit thinks about this before proceeding.

@dauriamarco dauriamarco force-pushed the fix/side-panel/fullscrenn-btn-visibility branch from 896c3a8 to 7d4f204 Compare February 20, 2026 12:13
@github-actions
Copy link

Code Coverage

@ljanner ljanner requested a review from spike-rabbit February 20, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

side-panel-content hide overlay button when already in fullscreen

2 participants