test: migrate from toBeTrue and toBeFalse to toBe#1567
Open
test: migrate from toBeTrue and toBeFalse to toBe#1567
Conversation
spliffone
force-pushed
the
test/use-tobe
branch
from
e9bc8ee to
9f8bedb
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates Jasmine assertions from toBeTrue() and toBeFalse() to toBe(true) and toBe(false) respectively across numerous test files. This is a good refactoring for consistency and clarity in the test suite. The changes are applied correctly throughout the codebase. I've added a couple of suggestions to make some assertions even more idiomatic, but overall this is a solid improvement.
|
Documentation. Coverage Reports: |
spliffone
force-pushed
the
test/use-tobe
branch
from
0e0f953 to
99adf3b
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #1071