feat(empty-state): make icon and description optional#1572
Open
dauriamarco wants to merge 1 commit intomainfrom
Open
feat(empty-state): make icon and description optional#1572dauriamarco wants to merge 1 commit intomainfrom
dauriamarco wants to merge 1 commit intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request successfully makes the icon input for the si-empty-state component optional. The changes are well-rounded, including updates to the component logic, template, API definition, and the addition of relevant tests and examples. The new examples for states with no icon and no description are particularly helpful. The suggestion to improve the robustness of a new unit test by using a more specific DOM selector has been retained. Overall, this is a solid contribution.
projects/element-ng/empty-state/si-empty-state.component.spec.ts
Outdated
Show resolved
Hide resolved
|
Documentation. Coverage Reports: |
dauriamarco
force-pushed
the
feat/empty-state/optional-elements
branch
from
759be7b to
5843f30
Compare
dauriamarco
force-pushed
the
feat/empty-state/optional-elements
branch
from
5843f30 to
e5edd3d
Compare
dauriamarco
force-pushed
the
feat/empty-state/optional-elements
branch
from
e5edd3d to
eec9ae8
Compare
|
|
panch1739
reviewed
Feb 26, 2026
Member
panch1739
left a comment
panch1739
left a comment
There was a problem hiding this comment.
@dauriamarco wow, you were super fast! Perfect!
I just have two comments:
- As now our icons occupy a bigger space in the grid, they look a bit out of balance with the rest of the text. I think we can align with iX and change the size to 64px by 64px:
- This is totally optional, but i think it would be cool if we could have a preview that allows users to toggle on and off the things that are optional...similar to what you did in the launchpad? WDYT?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1479