test(about): remove TestHostComponent wrapper in favor of inputBinding#1573
Merged
test(about): remove TestHostComponent wrapper in favor of inputBinding#1573
Conversation
Member
chintankavathia
commented
Feb 26, 2026
chintankavathia
commented
- I confirm that this MR follows the contribution guidelines.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modernizes the tests for SiAboutComponent by replacing the TestHostComponent pattern with the newer inputBinding API. This is a valuable refactoring that improves test clarity and simplicity. The changes are well-executed. My review includes one suggestion to improve naming consistency for the new signals, which will enhance maintainability.
|
|
Member
|
I like it! |
|
Documentation. Coverage Reports: |
spliffone
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.