Conversation
Introduces documentation for the date-time picker component, updates the input-date-time guide with expanded options and usage details, and refines the date-picker guide for consistency. Adds new Figma illustration assets for the updated documentation.
✅ Deploy Preview for industrial-experience ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Revised the 'Related' sections in date-picker, date-time-picker, input-date-time, and input-time documentation to add a link to writing guidelines for date and time, and to remove or reorder other related links for improved clarity and consistency.
Improved documentation for date picker, date-time picker, input-date-time, input-date, input-time, and time picker components with clearer option descriptions and behavior explanations. Added links to the W3C date picker accessibility reference for all related guides. Updated Figma illustration for date-time picker states.
Updated references to date picker and time picker states to point to the correct guide sections, ensuring documentation links work as intended.
|
/gemini review |
kathrinschalber
requested review from
flxlst09
and removed request for
flxlst09
|
@flxlst09 added you as a reviewer for the "actual" review. |
flxlst09
left a comment
flxlst09
left a comment
There was a problem hiding this comment.
Very good, only smaller suggestions. As discussed: Date time input usage guide will be hidden until the component is ready.
Updated internal documentation links in date picker, date-time picker, input-date, and input-date-time guides to point to more specific sections and correct files. This improves navigation and clarity for users referencing related options and components.
Improved explanations and formatting in guides for date-time-picker, input-date-time, input-date, and input-time components. Clarified range selection behavior, input formats, and updated references to related documentation for better usability and consistency.
Improved clarity and consistency in guides for date-time picker, input-date-time, input-date, and input-time components. Adjusted format descriptions, added details for week start and week numbers, and refined terminology for selected dates and current day.
kathrinschalber
left a comment
kathrinschalber
left a comment
There was a problem hiding this comment.
@alexkaduk I cannot request changes since I'm the PR author, however I found a few things to look at. Let me know if there are any doubts 😊
|
|
||
| ## Basic | ||
|
|
||
| <DatetimeInputPlayground height="28rem" /> |
There was a problem hiding this comment.
@alexkaduk please add a default value, similar to the date input.
Feedback on the component itself:
- I've noticed this "double border", it seems like there's 2 dropdowns stacked on top of each other:
- The confirm button isn't vertically centered
- In readonly mode, when I access the input through keyboard (=tab), I can still open the picker and edit the date. However, I noticed that this also happens on the date input
There was a problem hiding this comment.
1 default value is added
2 "double border" case is fixed. it required to wrap datetime-picker content (it is grid) with ix-date-time-card (case used by date and time picker)
3 same reason as "double border"
4 that is how it works as the moment. let me suggest to have new ticket for it and adjust date/time input components
There was a problem hiding this comment.
@alexkaduk Can we change the default value from 1/1/1970 to the current day?
There was a problem hiding this comment.
done. thanks for the feedback
4 participants
💡 What is the current behavior?
Missing a few usage guides
GitHub Issue Number: #
🆕 What is the new behavior?
Note: As the date time input doesn't exsit at this time, this is a first draft. In case it isn't finished once this PR is ready to be merged, I would hide it from the sidebar in the meanwhile.
👨💻 Help & support