web-ui: add support to flash with bmap + fixes #563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By moving it to the utils, we make it reusable from both the client, as well as from the webserver. Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
The StorageOpenHandler still required the mtda instance as second argument. Since the introduction of the Pyro proxy, this interface does not exist anymore and needs to be ported to the new remote_call proxy. This apparently was forgotten for the storage_open API, hence these requests (like storage-write) always failed. Fixes: 7e13aac ("fix(www): create a Pyro proxy from the worker ...") Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
The mtda-cli already supports to write the image using a bmap file. By that, writing images with large holes is speedup a lot. Further, the image data ranges are checksumed. We now implement the same feature for the web UI as well. Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
Member
Author
|
Note, that the UI is still not hardened against any sort of user-error (e.g. flashing while the storage is attached to target, multiple clicks on upload, etc...). We should really improve at this frontier, as currently the chances to break MTDA by an erroneous click in the UI is quite high. Also, errors are not reported back to the user at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mtda-cli already supports to write the image using a bmap file. By that, writing images with large holes is speedup a lot. Further, the image data ranges are checksumed. We now implement the same feature for the web UI as well.