Draft
Conversation
scott-cotton
requested review from
arjun-sd,
daniel-de-vera,
foxish and
jmsktm
also add go to path of user
- use features where we can - mount .signadot and .kube to -localhost variants - use post-create.sh to install .signadot/config.yaml
- attempt to munge kubeconfig - install kubectl doesn't work yet w/ minikube b/c of certs thinking of adding a tcp proxy from localhost to host.docker.internal for ports in kube-config cluster servers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a devcontainer, which can be useful as a reference for running the cli within docker and standardising build.
There is also a
make devcontainerwhich builds and places the CLI binary and sets GOARCH. This means the devcontainer build from VSCode won't work unless one runsgo build -o .devcontainer/signadot ./cmd/signadotfirst.This is somewhat a work in progress. It only works w/ aws and signadot local type "PortForward", I'd like to add
I think it will work with type "ProxyAddress"
and figure out how to make a devcontainer feature, so it is easy for folks to add signadot to a devcontainer.
But, it may be useful as is.
Thoughts appreciated.