Magento 2.4.7: Fix parent constructor call in Abandoned Grid

[tomreece]

In the recently released Magento 2.4.7 I am getting this error:

treece@Toms-Work-MacBook treece1 % bin/magento setup:di:compile
Compilation was started.
Interception cache generation... 6/9 [==================>---------]  66% 30 secs 492.0 MiBErrors during compilation:
	Signifyd\Connect\Block\Adminhtml\Shopcart\Abandoned\Grid
		Incompatible argument type: Required type: \Magento\Framework\Url\DecoderInterface. Actual type: array; File:
/Users/treece/mystic-mountain/treece1/vendor/signifyd/module-connect/Block/Adminhtml/Shopcart/Abandoned/Grid.php

Total Errors Count: 1

In Log.php line 92:

  Error during compilation


setup:di:compile

I think the call to this parent Grid constructor is incorrect but I'm not 100% sure
https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Reports/Block/Adminhtml/Shopcart/Abandoned/Grid.php#L45

After this change, setup:di:compile works as expected in Magento 2.4.7 using PHP 8.3

[valenciaisaza]

Waiting for this fix to be merged, to update Magento

[gabriel3iri]

Do you guys know when this will be merged? my company is updating to 2.4.7 and this is kinda holding us back. Thanks

[tomreece]

👋 Any update?

[SeanWahoo]

Can’t you just create a plugin or install it into the apps directory with the modification? We all get your update queries. If this is really holding up your companies advancement then you could easily get around the official distribution not including this change.

…

________________________________ From: Tom Reece ***@***.***> Sent: Friday, April 26, 2024 10:18:02 AM To: signifyd/magento2 ***@***.***> Cc: Subscribed ***@***.***> Subject: Re: [signifyd/magento2] Magento 2.4.7: Fix parent constructor call in Abandoned Grid (PR #66) 👋 Any update? — Reply to this email directly, view it on GitHub<#66 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AD7CLXM5437HLDGJH5BOAWDY7JOZVAVCNFSM6AAAAABGBAECY2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZZGQ4DONBWGA>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[tomreece]

@SeanWahoo That's what we've done for our test instances but what about real users who use the Signifyd extension directly from official. I guess they'll figure it out or ask us for a patch. 🤷

[mantis4444]

Bro, you need to check the parent. You have to pass $urlDecoder and $parameters, not null. It will not break because parent constructs them anyways in case of null. Still better to keep the flexibility and do it correctly.

[ebanolopes]

Hello, Ébano, from Signifyd. We'll be releasing a new version on the upcoming weeks. This PR will not be directly merged as we need to change somethings due to other changes on our end. Find on below link a patch with the official solution which will get released soon.

https://osfglobalinc-my.sharepoint.com/:u:/g/personal/ebano_lopes_osf_digital/EcJMW1Ne0xBCg83uri9pN74BcMIjlbYhpKSszarETJxfdA?e=SAyInd