Skip to content

Sandbox Process Creation #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pixeebot wants to merge 2 commits into from
Closed

Sandbox Process Creation #470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3396c25
Sandbox Process Creation
pixeebot[bot] Dec 21, 2024
588f5e8
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion examples/other_languages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
import sys
from subprocess import PIPE, Popen

from security import safe_command

from sigopt import Connection


Expand All @@ -23,7 +25,7 @@ def evaluate_metric(self, assignments):
arguments = [
"--{}={}".format(param_name, assignment) for param_name, assignment in assignments.to_json().iteritems()
]
process = Popen(self.command.split() + arguments, stdout=PIPE, stderr=PIPE)
process = safe_command.run(Popen, self.command.split() + arguments, stdout=PIPE, stderr=PIPE)
(stdoutdata, stderrdata) = process.communicate()
sys.stderr.write(stderrdata)
return float(stdoutdata.strip())
Expand Down
1 change: 1 addition & 0 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,5 @@ packaging>=21.3
pypng>=0.0.20
PyYAML>=5,<7
requests>=2.25.0,<3.0.0
security==1.3.1
Copy link
Contributor Author

@pixeebot pixeebot bot Dec 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This library holds security tools for protecting Python API calls.

License: MIT ✅ Open Source ✅ More facts

urllib3>=1.26.5,<2.0.0
4 changes: 3 additions & 1 deletion sigopt/cli/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import threading

import click
from security import safe_command

from sigopt.factory import SigOptFactory
from sigopt.run_context import GlobalRunContext
Expand Down Expand Up @@ -80,7 +81,8 @@ def run_subprocess_command(config, run_context, cmd, env=None):
env = get_subprocess_environment(config, run_context, env)
proc_stdout, proc_stderr = subprocess.PIPE, subprocess.PIPE
try:
proc = subprocess.Popen(
proc = safe_command.run(
subprocess.Popen,
cmd,
env=env,
stdout=proc_stdout,
Expand Down
Loading