Skip to content

Use events API to eager send attestations #7892

Merged
mergify[bot] merged 84 commits intosigp:release-v8.1from
hopinheimer:eager-send-attestation
Feb 4, 2026
Merged

Use events API to eager send attestations #7892
mergify[bot] merged 84 commits intosigp:release-v8.1from
hopinheimer:eager-send-attestation

Conversation

@hopinheimer
Copy link
Member

@hopinheimer hopinheimer commented Aug 18, 2025

@hopinheimer hopinheimer self-assigned this Aug 18, 2025
@hopinheimer hopinheimer added the val-client Relates to the validator client binary label Aug 18, 2025
@jimmygchen jimmygchen added the waiting-on-author The reviewer has suggested changes and awaits thier implementation. label Sep 10, 2025
@hopinheimer hopinheimer added ready-for-review The code is ready for review waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. ready-for-review The code is ready for review labels Sep 19, 2025
@hopinheimer hopinheimer removed the waiting-on-author The reviewer has suggested changes and awaits thier implementation. label Sep 20, 2025
@hopinheimer hopinheimer added the ready-for-review The code is ready for review label Sep 20, 2025
@michaelsproul michaelsproul added the v8.1.0 Post-Fulu release label Oct 15, 2025
@michaelsproul
Copy link
Member

michaelsproul commented Feb 3, 2026

@hopinheimer We realised that the fallback to the other BNs wouldn't work due to the main loop waiting for the next slot on failure. So we've refactored quite substantially so that:

  • On head event: request attestation data from that BN and check that it matches the expected head.
  • If that works, we have our attestation data, proceed as before.
  • If that doesn't work, wait until attestation deadline then run first_success on all nodes to get attestation data.

These changes are in this commit:

In the process of this change I deleted first_success_from_index and adapted its tests (simpler now). I also made spawn_attestation_tasks async so we can just fetch the attestation data inline, and adjusted some of the math to account for this (avoiding calculating duration_to_next_slot early in case attestation data production takes substantial time (expected), and being explicit about which slot we are waiting for).

@michaelsproul michaelsproul added the ready-for-merge This PR is ready to merge. label Feb 4, 2026
@mergify mergify bot added the queued label Feb 4, 2026
@mergify
Copy link

mergify bot commented Feb 4, 2026

Merge Queue Status

🚫 The pull request has left the queue (rule: default) at 0e9dab3

This pull request spent 25 minutes 8 seconds in the queue, including 22 minutes 56 seconds running CI.
The checks were run on draft #8740.

Required conditions to merge
  • check-success=local-testnet-success
  • check-success=test-suite-success

Reason

The merge conditions cannot be satisfied due to failing checks

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

mergify bot added a commit that referenced this pull request Feb 4, 2026
@mergify mergify bot added dequeued and removed queued labels Feb 4, 2026
@michaelsproul
Copy link
Member

@mergify requeue

@mergify
Copy link

mergify bot commented Feb 4, 2026

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify
Copy link

mergify bot commented Feb 4, 2026

Merge Queue Status

✅ The pull request has been merged at 0e9dab3

This pull request spent 33 minutes 11 seconds in the queue, including 30 minutes 53 seconds running CI.
The checks were run on draft #8745.

Required conditions to merge
  • check-success=local-testnet-success
  • check-success=test-suite-success

@mergify mergify bot added queued and removed dequeued labels Feb 4, 2026
mergify bot added a commit that referenced this pull request Feb 4, 2026
mergify bot added a commit that referenced this pull request Feb 4, 2026
@michaelsproul
Copy link
Member

@mergify dequeue

@mergify
Copy link

mergify bot commented Feb 4, 2026

dequeue

✅ The pull request has been removed from the queue

@michaelsproul
Copy link
Member

@mergify requeue

@mergify
Copy link

mergify bot commented Feb 4, 2026

requeue

☑️ This pull request is already queued

@mergify mergify bot merged commit bd19663 into sigp:release-v8.1 Feb 4, 2026
37 checks passed
@mergify mergify bot removed the queued label Feb 4, 2026
dapplion added a commit to MoeMahhouk/lighthouse that referenced this pull request Feb 10, 2026
Removes changes from sigp#7892 (beacon head monitor), sigp#8748 (bootnode fix),
and sigp#8749 (v8.1.0 release) that were inadvertently pulled in by merging
stable into this branch. These are not part of the deb-packaging work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge This PR is ready to merge. v8.1.0 Post-Fulu release val-client Relates to the validator client binary

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants