Conversation
andreahn
reviewed
Feb 27, 2026
Comment on lines
+1846
to
+1852
| var size = entityType.getEntityKeys().keys().stream() | ||
| .flatMap(key -> key.getKeys().stream()) | ||
| .toList() | ||
| .size(); | ||
|
|
||
| if (size > 22) | ||
| addErrorMessage("Total amount of key columns in type %s can't be greater than 22.", entityType.getName()); |
Collaborator
...raphitron-java-codegen/src/test/java/no/sikt/graphitron/validation/EntityValidationTest.java
Outdated
Show resolved
Hide resolved
...raphitron-java-codegen/src/test/java/no/sikt/graphitron/validation/EntityValidationTest.java
Outdated
Show resolved
Hide resolved
.../graphitron-java-codegen/src/test/resources/validation/entity/keyIsReference/schema.graphqls
Outdated
Show resolved
Hide resolved
...ent/graphitron-java-codegen/src/test/resources/validation/entity/tooManyKeys/schema.graphqls
Show resolved
Hide resolved
...-java-codegen/src/main/java/no/sikt/graphitron/validation/ProcessedDefinitionsValidator.java
Outdated
Show resolved
Hide resolved
Erkelinux
reviewed
Mar 3, 2026
Comment on lines
+67
to
+71
| @DisplayName("Total amount of keys exceeds 22 across multiple @key directives") | ||
| void tooManyKeysSplit() { | ||
| assertErrorsContain("tooManyKeysSplit", | ||
| "Total amount of key columns in type Customer can't be greater than 22."); | ||
| } |
Collaborator
There was a problem hiding this comment.
Litt kjedelig at vi ender opp med denne valideringen, og derfor vil jeg gjøre et lite forsøk på å fjerne problemet i stedet.
Collaborator
Author
There was a problem hiding this comment.
Ja, vi kan ju gott fjerne dette om du löser problemet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.