Skip to content

Conversation

@cviebrock
Copy link
Contributor

@cviebrock cviebrock commented Jul 18, 2025

Description

  • Converts 'SomeClass' to SomeClass::class throughout
  • uses SwatDBClassMap::new() instead of instantiating class-name variables
  • adds dataobject docblocks to the (one) data object class
  • minor other changes to PHP logic and type hinting to help with static analysis

Testing Instructions (optional)

Add step-by-step instructions for testing the PR, if necessary.

  1. Check out this PR
  2. CI should pass

Developer Checklist

Before requesting review for this PR, make sure the following tasks are
complete:

  • I added a link to the relevant Shortcut story, if applicable
  • I added testing instructions, if any
  • I made sure existing CI checks pass
  • I checked that all requirements of the ticket are fulfilled

Reviewer Checklist

Before merging this PR, make sure the following tasks are complete:

  • I made sure there are no active labels that block merge
  • I followed the testing instructions
  • I made sure the CI checks pass
  • I reviewed the file changes on GitHub
  • I checked that all requirements of the ticket (if any) are fulfilled

@gauthierm gauthierm merged commit 31ffba5 into silverorange:master Jul 25, 2025
1 of 2 checks passed
@cviebrock cviebrock deleted the add-dataobjects branch July 25, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants