Skip to content

Conversation

@martinRenou
Copy link
Member

@martinRenou martinRenou commented Jul 5, 2017

The datatable component should only take care of rendering the datatable. As buttons for global actions are not part of the datatable itself, I think it's better to render them from the components which render the datatable.
Furthermore, it allows us to render those buttons inside the box-tools element provided by AdminLTE, which is the proper place for those buttons, it improves the visual aspect.

@martinRenou martinRenou changed the title Extract global action from datatable Extract globals action from datatable Jul 5, 2017
@codecov-io
Copy link

codecov-io commented Jul 5, 2017

Codecov Report

Merging #540 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #540   +/-   ##
=======================================
  Coverage   95.18%   95.18%           
=======================================
  Files          85       85           
  Lines        3905     3905           
  Branches      247      247           
=======================================
  Hits         3717     3717           
  Misses        137      137           
  Partials       51       51

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff8c77b...11e2ee6. Read the comment docs.

@martinRenou martinRenou changed the title Extract globals action from datatable Extract global actions from datatable Jul 5, 2017
@martinRenou martinRenou requested a review from stefanoborini July 5, 2017 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants