Skip to content

Conversation

@bphillips201
Copy link
Contributor

Provides FlowType functionality using CSS.

Updated to exclude line-height calculation (v1.1)

@yckart
Copy link

yckart commented Mar 17, 2016

Is there a reason why you use px instead of relative sizing? When sizes are defined in pixels, nothing will change (in some browsers) if the visitor adjusts their default font-size (http://gomakethings.com/working-with-relative-sizing/).

I also miss the !default flag, which makes it possible to override those values (http://sass-lang.com/documentation/file.SASS_REFERENCE.html#variable_defaults_).

...or, do it without global variables:

@mixin flowtype($maximum: 500, $minimum: 1200, $maxFont: 12, $minFont: 40, $fontRatio: 30) { ... }

Also to note, viewport units...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants