Add CI workflow to build CrossBasic on Linux and Windows #2
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
.github/workflows/build.yml
Outdated
| - name: Install Linux dependencies | ||
| if: matrix.os == 'ubuntu-latest' | ||
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get install -y g++ libffi-dev |
There was a problem hiding this comment.
The Linux matrix job later runs ./build_appserver.sh, which links against -lboost_system -lboost_thread and requires Boost headers, but the Linux dependency step only installs g++ and libffi-dev. There are no Boost libraries in the repo, so on ubuntu-latest the app server link will consistently fail with missing -lboost_*, causing the Linux build to fail every run.
Useful? React with 👍 / 👎.
| - name: Build on Windows | ||
| if: matrix.os == 'windows-latest' | ||
| run: | | ||
| call build_all_windows.bat | ||
| shell: cmd |
There was a problem hiding this comment.
The Windows matrix job calls build_all_windows.bat, which invokes build_appserver.bat linking against Boost static libs (libboost_system-mgw14-mt-s-x64-1_87.a, libboost_thread-mgw14-mt-s-x64-1_87.a). The workflow only installs MinGW and a Rust toolchain and the repository contains no Boost binaries, so on windows-latest the link step will fail with missing Boost libraries and the Windows build will never succeed.
Useful? React with 👍 / 👎.
simulanics
deleted the
codex/create-github-actions-workflow-for-crossbasic-builds
branch
Summary
Testing
Codex Task