Improved testing, documentation and some minor hygiene factors#87
Closed
rchick wants to merge 8 commits intosindresorhus:mainfrom
Closed
Improved testing, documentation and some minor hygiene factors#87rchick wants to merge 8 commits intosindresorhus:mainfrom
rchick wants to merge 8 commits intosindresorhus:mainfrom
Conversation
Bumps [xo](https://github.com/xojs/xo) from 0.60.0 to 1.1.0. - [Release notes](https://github.com/xojs/xo/releases) - [Commits](xojs/xo@v0.60.0...v1.1.0) --- updated-dependencies: - dependency-name: xo dependency-version: 1.1.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [c8](https://github.com/bcoe/c8) from 9.1.0 to 10.1.3. - [Release notes](https://github.com/bcoe/c8/releases) - [Changelog](https://github.com/bcoe/c8/blob/main/CHANGELOG.md) - [Commits](bcoe/c8@v9.1.0...v10.1.3) --- updated-dependencies: - dependency-name: c8 dependency-version: 10.1.3 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bump xo from 0.60.0 to 1.1.0
Bump c8 from 9.1.0 to 10.1.3
Owner
|
I appreciate the pull request. However, I'm not interested in all of this. I'm happy to add some more tests. All tests should be added to the main test file. |
Author
ok cool, I'll come up with a simplified version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improved testing, documentation and some minor hygiene factors
Type of Change
Checklist