This to remove the existing keys if it is not present in the keys#69
Open
karthikcmc wants to merge 1 commit intosingleplatform-eng:masterfrom
Open
This to remove the existing keys if it is not present in the keys#69karthikcmc wants to merge 1 commit intosingleplatform-eng:masterfrom
karthikcmc wants to merge 1 commit intosingleplatform-eng:masterfrom
Conversation
…le . It would be addressing the issue raised in the Removing ssh keys singleplatform-eng#56
|
@davidpanofsky Please, can you review and merge this? |
Member
|
I can see the value of this change, but think it might be better to make this behavior something one can opt in/out of. Concerned that with this change, manually added entries would be cleaned up which could be confusing. Also, note that I'm no longer actively a member of the team which owns this repo. I'll reach out to see if I can get someone to take it on for a faster response in the future. |
|
How is this going on? The current behavior keeps every key which was added. So if someone adds an unknown key, a very bad backdoor gets opened! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the authorized_keys module used in this role is updated with exclusive attribute . It would be addressing the issue raised in the Removing ssh keys #56.