refactor(stage): create an abstraction for file locations #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunogoncalves03
changed the title
nunogoncalves03
changed the title
nunogoncalves03
force-pushed
the
ngoncalves/file-location-refactor
branch
from
6942115 to
2f0a82d
Compare
nunogoncalves03
had a problem deploying
to
Base
GitHub Actions
Failure
kesmit13
requested changes
Dec 2, 2024
nunogoncalves03
force-pushed
the
ngoncalves/file-location-refactor
branch
from
2f0a82d to
9f2fc6d
Compare
kesmit13
approved these changes
Dec 2, 2024
kesmit13
reviewed
Dec 2, 2024
Collaborator
kesmit13
left a comment
kesmit13
left a comment
There was a problem hiding this comment.
It looks like *.ipynb needs to be added to the options.package_data in setup.cfg. The notebook files are not being installed in the test directory.
nunogoncalves03
force-pushed
the
ngoncalves/file-location-refactor
branch
from
cd2fbb9 to
b831054
Compare
nunogoncalves03
had a problem deploying
to
Base
GitHub Actions
Failure
nunogoncalves03
had a problem deploying
to
Base
GitHub Actions
Failure
nunogoncalves03
force-pushed
the
ngoncalves/file-location-refactor
branch
from
8e2fc5b to
fc5bbaa
Compare
nunogoncalves03
had a problem deploying
to
Base
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have recently updated the
Management APIto include new endpoints for managing files in personal and shared spaces. Thus, we would like to update thePython SDKto support these resources as well.Since the methods for stage files and personal/shared space files are quite similar, we would like to refactor the
Python SDKby introducing an abstract class calledFileLocation. This class will initially be implemented byStageand later by the other file spaces.This PR introduces the abstract class and modifies the previously implemented file objects to make them generic for future use with other file spaces.
cc: @ricardoasmarques @kanitsharma