Skip to content

Non regular TwoLevelTree and StrategicScenarioss#90

Merged
JulStraus merged 4 commits intomainfrom
fix/strat_scen
Feb 27, 2026
Merged

Non regular TwoLevelTree and StrategicScenarioss#90
JulStraus merged 4 commits intomainfrom
fix/strat_scen

Conversation

@JulStraus
Copy link
Collaborator

This PR implements the suggestion of @trulsf in #89 for solving the issue in which StrategicScenarios cannot be iterated for non regular TwoLevelTree structures, that is structures in which the operational structure of the individual StratNodes is not the same.

@JulStraus JulStraus requested a review from trulsf February 26, 2026 14:40
@JulStraus JulStraus added the bug Something isn't working label Feb 26, 2026
@JulStraus
Copy link
Collaborator Author

I have to admit that I am confused over the Unbound error here in the LTS test. I would say we have to possibilities,

  1. remove the testing for unbound (In this case, I do neither see and unbound parameter) or
  2. merge without LTS test passing (fine for me as the unbound type is a bit weird).

Copy link
Member

@trulsf trulsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I would suggest leaving out the unbounded type parameter test of Aqua for the time being, and see if the lts behaviour changes later. I can not see any problems with the unbounded type parameters, at least not in practice.

@JulStraus
Copy link
Collaborator Author

Looks good. I would suggest leaving out the unbounded type parameter test of Aqua for the time being, and see if the lts behaviour changes later. I can not see any problems with the unbounded type parameters, at least not in practice.

I will remove it then. On a side not, as it is a bug, I think we should also register a new version. I will hence as well increase the minor version number.

@trulsf
Copy link
Member

trulsf commented Feb 27, 2026

Good, I will trigger a new release.

@JulStraus JulStraus merged commit b20b272 into main Feb 27, 2026
6 checks passed
@JulStraus JulStraus deleted the fix/strat_scen branch February 27, 2026 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants