-
Notifications
You must be signed in to change notification settings - Fork 24
Updated dunes.js, updated .env.example the env fee was set way too high, and I updated Unspent API and ORD endpoints in env, added support for images for dunes through parent child, added "Apply Pay Terms" from PR, added a valid wallet example, and fixed the readme to reflect updates an changes. Much Pull Request!! So Approve!!! #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GreatApe42069
wants to merge
16
commits into
sirduney:master
Choose a base branch
from
GreatApe42069:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated fee and Unspent API and ORD endpoints Signed-off-by: GreatApe42069 <153969184+GreatApe42069@users.noreply.github.com>
Lowered Fee, it was set too high Signed-off-by: GreatApe42069 <153969184+GreatApe42069@users.noreply.github.com>
…ployOpenDune` and fixed `getrawtx` function This commit introduces two key updates to the `dunes.js` script Updated dunes.js with parent image feature: Added `[parentId]` to `deployOpenDune` and fixed `getrawtx` function This commit introduces two key updates to the `dunes.js` script: 1. **Added `parentId` Parameter to `deployOpenDune`**: - The `deployOpenDune` command now accepts an optional `[parentId]` parameter. This allows users to link a new Dune to a parent inscription by spending its UTXO, enabling hierarchical relationships between inscriptions (inspired by the Doginals protocol). - **Example**: `node dunes.js deployOpenDune "MY•CHILD•DUNE" "Đ" 10 8 null 0 0 0 0 0 true true e6c6efe91b6084eae2c8a2fd6470d3d0dbfbb342f1b8601904f45be8095058e2i0` 2. **Fixed `getrawtx` Function**: - Corrected the `getrawtx` function to properly accept a transaction ID (`txid`) string and pass it to the `getrawtransaction` RPC method, resolving a bug that caused invalid parameter errors. These updates are backward - compatible - existing commands like `printDunes`, `sendDuneMulti`, and `mintDune` will work as before unless the new `parentId` parameter is specified, function is only called by fetchParentUtxo, which is only used when parentId is provided. If you don’t use "Optional" `parentId`, `getrawtx` isn’t even touched, so existing commands (`printDunes`, `sendDuneMulti`, etc.) are unaffected. The script has been tested on the Dogecoin testnet and is ready for mainnet deployment, provided all dependencies and environment variables are correctly configured. This updated script is correct and won’t fuck up the existing dunes.js functionality. The parentId addition is cleanly integrated, only kicking in when used, and the `getrawtx` update fixes a bug without rippling out to other parts. You can deploy Dunes with or without a parent inscription, and everything else like (sending, minting, deploying, syncing) keeps humming along as before. Before, passing tx.toString() was nonsense for an RPC call expecting a txid string. Now, it takes the txid directly (e.g., e6c6...), which is what getrawtransaction needs. The params: [txid, true] ensures verbose output, giving you the full transaction details (like vout data) needed for fetchParentUtxo. Signed-off-by: GreatApe42069 <153969184+GreatApe42069@users.noreply.github.com>
Signed-off-by: GreatApe42069 <153969184+GreatApe42069@users.noreply.github.com>
Signed-off-by: GreatApe42069 <153969184+GreatApe42069@users.noreply.github.com>
…" inscription (e.g., an image or another Dune) using the optional `[parentId]` Signed-off-by: GreatApe42069 <153969184+GreatApe42069@users.noreply.github.com>
update broken ORD= link Signed-off-by: GreatApe42069 <153969184+GreatApe42069@users.noreply.github.com>
Signed-off-by: GreatApe42069 <153969184+GreatApe42069@users.noreply.github.com>
Signed-off-by: GreatApe42069 <153969184+GreatApe42069@users.noreply.github.com>
…h parent-child relationships logic Signed-off-by: GreatApe42069 <153969184+GreatApe42069@users.noreply.github.com>
Much pull request Such Approved "apply pay terms” is the Key: it lets you set a mint price (in “shibes”) and specify who gets paid when someone mints a Dune. Previously, we could only open‐mint with limits, caps, and block‑height restrictions, etc.; now we can also monetize it by charging a fee and directing that fee to an address of your choice. You also refactored the internal broadcast() function’s retryAsync call so it passes the helper directly instead of wrapping it in an extra async lambda: res = await retryAsync(async () => await makePostRequest(), 10, 30000); res = await retryAsync(makePostRequest, 10, 30000); This doesn’t change behavior, it does makes the retry logic a bit cleaner! Why im Digging this upgrade??? Monetization: Projects can now sustainably fund themselves by charging a shibe‑denominated mint fee. Flexibility: Since the fee is just another field in the Terms object, it’s fully optional, so if you don’t want a fee, you pass "null" and everything behaves exactly like before. Such Flexibility!!! Backward‑compatible: Existing scripts and deployments that never set a price will continue to work unchanged. Decentralization & Dogecoin ethics: On‑chain enforcement only: All the fee logic happens in your local CLI client and then on‑chain via the same RPC calls and smart‑contract‑style logic Dunes has always used. There’s no off‑chain "Gatekeeper" or "Centralized service" validating payments. User choice: Anyone can deploy an open mint with or without a fee; you’re not forced to pay if you don’t want to. Transparent rules: All parameters (limits, heights, offsets, fees, pay‑to address) are encoded in the same public transaction data we’ve always put on Dogecoin. No new trust assumptions: You still only need to trust the Dogecoin network itself and your own keypair....there’s no additional trusted infrastructure introduced. In short, it’s Such a clean, opt‑in extension that preserves the fully decentralized ethos of Dogecoin. Much Innovation, Such Decentralized, So Dunes Well done Fam! Thanks for the Great Idea @reallyshadydev https://x.com/reallyshadydev Signed-off-by: GreatApe42069 <153969184+GreatApe42069@users.noreply.github.com>
…buting still need to add duneys address Signed-off-by: GreatApe42069 <153969184+GreatApe42069@users.noreply.github.com>
updated env to use correct example Signed-off-by: GreatApe42069 <153969184+GreatApe42069@users.noreply.github.com>
added npm audit fix instead, so it updates everything Signed-off-by: GreatApe42069 <153969184+GreatApe42069@users.noreply.github.com>
example of valid .wallet.json Signed-off-by: GreatApe42069 <153969184+GreatApe42069@users.noreply.github.com>
Signed-off-by: GreatApe42069 <153969184+GreatApe42069@users.noreply.github.com>
GreatApe42069
commented
Jul 26, 2025
Author
GreatApe42069
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Such Approve!!!!
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Updated env fee was set way too high, and I updated Unspent API and ORD endpoints in env