siren-0.8.x bump netty 4.1.27-3 #9
Conversation
| package org.apache.arrow.vector; | ||
|
|
||
| import io.netty.buffer.ArrowBuf; | ||
| import siren.io.netty.buffer.ArrowBuf; |
There was a problem hiding this comment.
Does that mean we weren't always using the custom changes of netty we did ?
There was a problem hiding this comment.
Yes, for vector, but this was fixed after this release 0.8.0
| <unsubscribe>dev-unsubscribe@arrow.apache.org</unsubscribe> | ||
| <post>dev@arrow.apache.org</post> | ||
| <archive>http://mail-archives.apache.org/mod_mbox/arrow-dev/</archive> | ||
| <archive>https://mail-archives.apache.org/mod_mbox/arrow-dev/</archive> |
There was a problem hiding this comment.
You're right, this is not needed, event if the good url is with the https. Shall I revert ?
There was a problem hiding this comment.
I think it's better to leave it as it is originally, this way we have less changes.
You're right, the PR should probably be renamed. For what I could see, the release 0.8.0 was not a "ready to use" project (even if good for third parties of course), it was not compiling as is when going to snapshot due to package rename (via shade plugin). This was fixed after this release, so nothing to report to master branch. |
No description provided.