Skip to content

Comments

Add support of AMD and CommonJS modules#77

Open
Forkiy wants to merge 4 commits intositexw:masterfrom
Forkiy:master
Open

Add support of AMD and CommonJS modules#77
Forkiy wants to merge 4 commits intositexw:masterfrom
Forkiy:master

Conversation

@Forkiy
Copy link

@Forkiy Forkiy commented Mar 7, 2018

No description provided.

@dev-bjoern
Copy link

@sitexw can you merge this pull request? Installing this via npm and would like to be able importing it.

@sitexw
Copy link
Owner

sitexw commented Dec 17, 2018

Can you repeat the merge request with correct indentation?
Thank you, and sorry for the response time.

@dev-bjoern
Copy link

@Forkiy, could you repeat the merge request with correct indentation? Many thanks!

@Forkiy
Copy link
Author

Forkiy commented Jan 9, 2019

Done! @sitexw can you please check? Also I am make same pull request to BlockAdBlock repo sitexw/BlockAdBlock#27. Please check it too.

@sitexw
Copy link
Owner

sitexw commented Jan 10, 2019

I feel like we are starting to be good!
I just spotted one last problem, in FuckAdBlock readme.md, you mention BlockAdBlock instead of FuckAdBlock.

@Forkiy
Copy link
Author

Forkiy commented Jan 10, 2019

@sitexw Fixed. Please check.

@radiantmediaplayer
Copy link

Is there a way we can fast-track to have it merged?

@resynth1943
Copy link

Is there a way we can fast-track to have it merged?

This module seems to be abandoned, so I'm doubting that's going to happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants