feat(hitl): generate ActionsTable records for tool-based flows #133
+406
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements Issue #128 - the key fix that makes HITL work for refunds/email transfers. Changes: - Add toolCalls and requiresApproval fields to DraftOutput type - Add useAgentMode option to draft step that uses runSupportAgent - Pass toolCalls through draft-response → validate-draft → handle-validated-draft - Create ActionsTable records with type 'tool-execution' for approval-requiring tools - Include toolCalls in SUPPORT_APPROVAL_REQUESTED event parameters - Add tests for tool-based approval detection logic The existing execute-approved-action.ts already handles toolCalls in parameters, so tool execution on approval should work end-to-end. Closes #128
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This implements Issue #128 - the key fix that makes HITL (Human-In-The-Loop) work for refunds and email transfers.
Changes
Type Updates
toolCallsandrequiresApprovalfields toDraftOutputtype intypes.tsSupportDraftCreatedEventandSupportDraftValidatedEventto include tool call fieldsDraft Step (
draft.ts)useAgentModeoption that usesrunSupportAgentinstead of rawgenerateTextprocessRefund,transferPurchase) are capturedrequiresApprovalbased on tool types usedPipeline Threading
draft-response.ts: Now enables agent mode and passestoolCalls/requiresApprovalthroughvalidate-draft.ts: Forwards tool call fields to downstream workflowshandle-validated-draft.ts:requiresApproval && hasToolCalls)ActionsTablerecords withtype: 'tool-execution'instead ofsend-drafttoolCallsin action parametersSUPPORT_APPROVAL_REQUESTEDwith correct action typeTests
Flow
processRefundtool callrequiresApproval: truedetected → ActionsTable record created withtype: 'tool-execution'execute-approved-actionprocesses the tool calls (already implemented)Acceptance Criteria
Note: Slack notification and integration testing will be verified in staging.
Closes #128