Open
Conversation
sman591
reviewed
Jun 22, 2017
lib/index.js
Outdated
| bsDropdown = BS.dropdown; | ||
| } | ||
| } catch (e) { | ||
| console.log('No bootstap'); |
Contributor
There was a problem hiding this comment.
The console.log shouldn't be necessary- not having bootstrap is supported & handled below
lib/index.js
Outdated
| var bsMultiselect = require('./bootstrap-multiselect.js'); | ||
| var bsDropdown; | ||
|
|
||
| var BS; |
Contributor
There was a problem hiding this comment.
It looks like BS is only used within try - it would help readability for the variable declaration to go there.
Author
|
It looks like it doesn't really solve the problem completely, the code is runnable but webpack still log an error when building, it's still an improvment |
Contributor
|
@jducro what Webpack error are you seeing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issues #73