Conversation
JacobConnorsUKAEA
left a comment
JacobConnorsUKAEA
left a comment
There was a problem hiding this comment.
Looks good. Great work 👍 💯 🎉
| inflammation_data = models.load_csv(filename) | ||
|
|
||
| view_data = {'average': models.daily_mean(inflammation_data), 'max': models.daily_max(inflammation_data), 'min': models.daily_min(inflammation_data)} | ||
| view_data = {'average': models.daily_mean(inflammation_data), 'max': models.daily_max(inflammation_data), 'min': models.daily_min(inflammation_data), **(models.s_dev(inflammation_data))} |
There was a problem hiding this comment.
I don't understand this but it seems right 👍
| import numpy as np | ||
| import numpy.testing as npt | ||
| import os | ||
|
|
There was a problem hiding this comment.
According to the course content, you're meant to have more tests in this file. What you should have is:
Standard deviation for one patient with multiple observations.
Standard deviation for two patients.
Graph includes a standard deviation graph.
Standard deviation function should raise an error if given empty data.
Computing standard deviation where deviation is different from variance.
Standard deviation function should give correct result given negative inputs.
Function should work with numpy arrays
| import numpy as np | ||
| import numpy.testing as npt | ||
| import os | ||
|
|
There was a problem hiding this comment.
According to the course content, you're meant to have more tests in this file. What you should have is:
Standard deviation for one patient with multiple observations.
Standard deviation for two patients.
Graph includes a standard deviation graph.
Standard deviation function should raise an error if given empty data.
Computing standard deviation where deviation is different from variance.
Standard deviation function should give correct result given negative inputs.
Function should work with numpy arrays
3 participants
No description provided.