Fix possible issues introduced by #272 #372
Draft
+10,371
−7,562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix NewSessionWizard runtime issues (expo-crypto UUID, TDZ, no setState-in-render) - Fix built-in profile duplication: ensure isBuiltIn=false + reset timestamps - Fix i18n drift: profiles.deleteConfirm is a function across languages; prevent en.ts drift via re-export - Fix expo-router typed routes for profile edit + settings/profiles; harden profileData parsing - Misc: remove unnecessary any; docs: CONTRIBUTING uses yarn
- Use explicit /(app) prefixes for settings/dev/changelog routes for consistency (CodeRabbit feedback on PR #7)
- Replace direct React Native Alert usage with Modal.confirm - DRY URL/template-string validation helper used by provider schemas (CodeRabbit feedback on PR #7)
- Refresh updatedAt when saving edits to existing custom profiles - Wrap settings profiles page component in React.memo per guidelines
- Use typedRoutes-friendly push targets for settings + profile-edit navigation - Avoids TS errors without changing runtime routing
- Fix NewSessionWizard runtime issues (expo-crypto UUID, TDZ, no setState-in-render) - Fix built-in profile duplication: ensure isBuiltIn=false + reset timestamps - Fix i18n drift: profiles.deleteConfirm is a function across languages; prevent en.ts drift via re-export - Fix expo-router typed routes for profile edit + settings/profiles; harden profileData parsing - Misc: remove unnecessary any; docs: CONTRIBUTING uses yarn
- Add permission chip + scroll-to-section behavior in wizard\n- Unify profile icons across wizard, chip bar, and picker\n- Align session type selector with ItemGroup styling
- Add accessible close button with web fallback navigation\n- Align picker right-side spacing for status/check/favorite\n- Add consistent selected indicator for path rows
- Move wizard machine search into a list-style group and filter inline\n- Render path picker search bar full-width (match machine picker)\n- Show selection indicator for No Profile row\n- Add separate settings toggles for machine/path picker search\n- Align env var card width with ItemGroup
- Fix profile selection param clearing + actions\n- Normalize tool-result content across providers\n- Preserve env var operator round-trips (:- vs :=)\n- Improve ItemGroup dividers with fragment support\n- Tighten modal typing; remove unsafe casts\n- Localize new UI strings + update locale files\n- Add targeted regression tests
- Support favoriting the default environment (empty profile id).\n- Avoid selection snaps after row actions by ignoring the next row press.\n- Stop auto-overriding selection from lastUsedProfile.
- Fix env-var docs/secret handling when value references another var - Ensure env-var template fallback operator persists - Refactor AgentInput new UI styles into Unistyles stylesheet - Clean up profile picker imports/indentation - Replace untyped react-test-renderer shim with @types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the merge of #272, issues have been reported by CodeRabbit in leeroybrun#6
Draft PR as I've not been able to test the changes implemented by #272 and this fix for now