Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
sloriot
left a comment
sloriot
left a comment
There was a problem hiding this comment.
Sorry for the very late reply. CGAL has been accepted as a mentoring orgs. So if you are still interested we can try to submit this project.
| } | ||
| #else | ||
| auto dot = this->begin()->north_ * clipNorth; | ||
| if( dot < -0.99984769515 ) { // about one degree |
There was a problem hiding this comment.
this should be a predicate not something based on a construction
There was a problem hiding this comment.
We need to check if we have existing predicates in the kernel and write new otherwise
|
|
||
| NT data_[4]; | ||
| }; | ||
| typedef CGAL::Exact_predicates_inexact_constructions_kernel K; |
There was a problem hiding this comment.
The kernel should not be hardcoded but be a template parameter
| NT vDot = this->begin()->vertex_ | clipNorth; | ||
| if( vDot >= _ray_spherical_eps ) { | ||
| #ifdef USE_EXACT_PREDICATE | ||
| Angle angle = compute_angle(this->begin()->vertex_, OrigVertex); |
There was a problem hiding this comment.
You can directly use https://doc.cgal.org/latest/Kernel_23/classKernel_1_1Angle__3.html, then you avoid a construction
|
Yes, I am interested in submitting this project. I will modify my code according to the feedback later. |
3 participants
Summary of Changes
use CGAL Vector_3 class and identify all the parts with predicates in convex hull intersection.
Release Management