Skip to content

Conversation

@manistal
Copy link

@manistal manistal commented Apr 28, 2025

Name of feature:

Matching Go Mod Go Level to Dep Level

Pain or issue this feature alleviates:

Go 1.14 does not support x/crypto 0.33.0

x/ packages don't support the backwards compat promise, so this go.mod stating Go 1.14 support, should ensure that the corresponding packages (x/crypto in this case) can support the stated Go level - Specifically, this creates a co-req with x/net 0.25.0 in most codebases which results in an error like (NetConn was added in Go 1.18).

tc.NetConn undefined (type *tls.Conn has no field or method NetConn) (compile)

0.14.0 is guarunteed to work with Go 1.14 which is the stated go mod compatibility level

Why is this important to the project (if not answered above):

go.mod should be consistent

Is there documentation on how to use this feature? If so, where?

Non-functional

In what environments or workflows is this feature supported?

All, this library does not depend on any x/crypto features from future releases and does not benefit from any version bumps.

In what environments or workflows is this feature explicitly NOT supported (if any)?

Supporting links/other PRs/issues:

💔Thank you!

@manistal
Copy link
Author

@hslatman This is a very small change to support backwards compatibility, lemme know if I should open an issue, but it looks like dependabot has been bumping this level without bumping the Go level - It should be a fully non-functional change based on the content of this repo

@hslatman
Copy link
Member

Hey @manistal, sorry that it took a while to get to this (again). I just looked at #50, and then saw this PR again. How can/should we determine which x/crypto version to pick based on the (minimum) Go version that we support? If I pick v0.14.0, I see Go 1.17 here: https://cs.opensource.google/go/x/crypto/+/refs/tags/v0.14.0:go.mod. Would it require checking which functions/types are used?

@hslatman hslatman self-assigned this Jul 29, 2025
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ Miguel Nistal
❌ manistal


Miguel Nistal seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants